feat: Show memory usage in the Benchmark tests #2733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 4, 2025 19:03
Member
|
This is very unlikely to produce reliable measurements without interacting with GC. What is the goal here? Are you after the allocation spike or leak detection? Are you concerned about memory consumption of a specific usecase? See
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: Show Memory usage in the benchmark tests
Description
We need to show the
memoryusage before and after each test. Since, we are currently using binaries of the engines and not the runtimes theprocessobject won't be available. So, I am creating a new script in thepackage.json(test:node). This will run the bundles file using node.Also, I will be writing another function named
logMemoryUsage. It will check if the process object is available it will call theprocess.memoryUsagefunction.Security Considerations
N/A
Scaling Considerations
N/A
Documentation Considerations
N/A
Testing Considerations
This PR in itself is addition to our new testing tool.
Compatibility Considerations
N/A
Upgrade Considerations
N/A